PR comments

PennyLaneAI · May 13, 2022 · ceff13b · ceff13b
1 parent 7368675
commit ceff13b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/pennylane_ionq/device.py b/pennylane_ionq/device.py
@@ -69,6 +69,7 @@ class IonQDevice(QubitDevice):
         wires (int or Iterable[Number, str]]): Number of wires to initialize the device with,
             or iterable that contains unique labels for the subsystems as numbers (i.e., ``[-1, 0, 2]``)
             or strings (``['ancilla', 'q1', 'q2']``).
+        gateset (str): the target gateset, either ``"qis"`` or ``"native"``.
         shots (int, list[int]): Number of circuit evaluations/random samples used to estimate
             expectation values of observables.
             If a list of integers is passed, the circuit evaluations are batched over the list of shots.

diff --git a/pennylane_ionq/ops.py b/pennylane_ionq/ops.py
@@ -20,8 +20,10 @@
 class GPI(Operation):  # pylint: disable=too-few-public-methods
     r"""GPI(phi, wires)
     Single-qubit GPI gate.
+
     .. math::
-        GPI(\phi) =
+
+       GPI(\phi) =
             \begin{pmatrix}
                 0 & e^{-i*2*\pi*\phi} \\
                 e^{-i*2*\pi*\phi} & 0
@@ -32,14 +34,16 @@ class GPI(Operation):  # pylint: disable=too-few-public-methods
     """
     num_params = 1
     num_wires = 1
-    grad_method = "None"
+    grad_method = None
 
 
 class GPI2(Operation):  # pylint: disable=too-few-public-methods
     r"""GPI2(phi, wires)
     Single-qubit GPI2 gate.
+
     .. math::
-        GPI2(\phi) =
+        
+       GPI2(\phi) =
             \begin{pmatrix}
                  1 & -i*e^{-i*2*\pi*\phi} \\
                  -i*e^{i*2*\pi*\phi} & 1
@@ -50,14 +54,15 @@ class GPI2(Operation):  # pylint: disable=too-few-public-methods
     """
     num_params = 1
     num_wires = 1
-    par_domain = "R"
-    grad_method = "None"
+    grad_method = None
 
 
 class MS(Operation):  # pylint: disable=too-few-public-methods
     r"""MS(phi1, phi2, wires)
     Single-qubit GPI2 gate.
+
     .. math::
+
             MS(\phi_0, _\phi_1) q_0, q_1 =
             \frac{1}{\sqrt{2}}\begin{pmatrix}
                 1 & 0         & 0 & -i*e^(-i*2*\pi*(\phi_0+\phi_1) \\
@@ -71,7 +76,7 @@ class MS(Operation):  # pylint: disable=too-few-public-methods
     """
     num_params = 2
     num_wires = 2
-    grad_method = "None"
+    grad_method = None
 
 
 # Custom operations for the QIS Gateset below