Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyUnicode_DATA and related APIs need to be disabled on PyPy #4040

Closed
davidhewitt opened this issue Apr 3, 2024 · 1 comment · Fixed by #4116
Closed

PyUnicode_DATA and related APIs need to be disabled on PyPy #4040

davidhewitt opened this issue Apr 3, 2024 · 1 comment · Fixed by #4116
Labels
bug Good First Issue

Comments

@davidhewitt
Copy link
Member

In pydantic/jiter#75 we had to not use PyUnicode_DATA for PyPy in a downstream project because it was segfaulting.

Probably all APIs which reach into PyUnicodeObject C struct need to be disabled for PyPy. Supported APIs are visible at https://github.com/PyO3/python3-dll-a/blob/main/src/libpypy3.10-c.def#L658-L735

Good first issue for anyone who wants to take a look at pyo3-ffi and how we declare the C APIs for our supported Python implementations.
@dmatos2012
Copy link
Contributor

I will give this one a try as well :)

@dmatos2012 dmatos2012 mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable PyUnicode_DATA on PyPy dmatos2012/pyo3
2 participants
@davidhewitt @dmatos2012