Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyModule: rename call* to call_function* #1467

Merged
merged 1 commit into from
Mar 4, 2021
Merged

PyModule: rename call* to call_function* #1467

merged 1 commit into from
Mar 4, 2021

Conversation

birkenfeld
Copy link
Member

For consistency with PyObject/PyAny, where call() means to call the object itself.

davidhewitt
davidhewitt approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me. I can't think of a better name.

Needs a CHANGELOG entry please!

kngwyu
kngwyu approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@birkenfeld birkenfeld changed the title [RFC] PyModule: rename call* to call_function* PyModule: rename call* to call_function* Mar 4, 2021
@birkenfeld
PyModule: rename call* to call_function*
e065f9b 
For consistency with PyObject/PyAny, where call() means to call the
object itself.
@davidhewitt davidhewitt merged commit 74fee84 into PyO3:master Mar 4, 2021
@davidhewitt davidhewitt mentioned this pull request Mar 13, 2021
Merged
@birkenfeld birkenfeld deleted the module_call branch May 21, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birkenfeld @davidhewitt @kngwyu