Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc updates #1268

Merged
merged 3 commits into from
May 5, 2022
Merged

Minor doc updates #1268

merged 3 commits into from
May 5, 2022

Conversation

iameskild
Copy link
Member

Fixes | Closes | Resolves #908 #1034

Please remove anything marked as optional that you don't need to fill in.
Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666).
If there is no issue, remove the line. Remove this note after reading.

Changes introduced in this PR:

  • Two minor doc updates before v0.4.1 release.

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild
Copy link
Member Author

@costrouc it's great hear that the CDSDashboard limitation documented here will be resolved, at it seems so from this comment.

How do you feel about keeping this note in until 0.4.2?

@iameskild iameskild requested review from viniciusdc and costrouc and removed request for viniciusdc May 4, 2022 20:44
@costrouc
Copy link
Member

costrouc commented May 4, 2022

@iameskild totally agree. Yes let's leave this comment in until the 0.4.2 release

@costrouc costrouc modified the milestone: Release v0.4.2 May 4, 2022
@iameskild iameskild added this to the Release v0.4.1 milestone May 5, 2022
@iameskild iameskild merged commit 4930909 into main May 5, 2022
@iameskild iameskild deleted the 20220504eae branch May 5, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy QHub on Minikube on Mac
2 participants