Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Utilities/Probability #60

Open
JCRPaquin opened this issue Mar 22, 2017 · 1 comment
Open

Issues with Utilities/Probability #60

JCRPaquin opened this issue Mar 22, 2017 · 1 comment

Comments

@JCRPaquin
Copy link

JCRPaquin commented Mar 22, 2017

I've been extending Utilities/Probability for a little bit with additional probability distribution sampler functions and have a couple of gripes:

  • As far as I can tell Utilities/Probability is currently a normal distribution single-sampler and doesn't actually deal with larger concepts involving probability. This makes the module name appear to be a misnomer. I propose that it be renamed Utilities/Distributions, Utilities/Stats, or something similar.

  • Further, the inclusion of the Distribution suffix in the module's functions is redundant. We already know that the module is about "Probability" and so exported function names should be obvious.

  • BoxMuller is an implementation detail that should not be exposed to module consumers.

  • Using single-sampler functions, functions that only sample one value from the distribution in question, does not allow us to abuse the strengths of accept-reject sampling methods to their fullest.

@JCRPaquin JCRPaquin changed the title Issues with Utilities/Probability Issues with Utilities/Probability Mar 22, 2017
@Quenty
Copy link
Owner

Quenty commented Nov 21, 2017

TODO: Rename to Stats, remove redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants