Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRDM-48126] Add support for httpx>=0.28.0 #12

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

yacchin1205
Copy link

@yacchin1205 yacchin1205 commented Dec 17, 2024

Creating folders becomes creating empty files when used with httpx >= 0.28.0 due to the following changes to httpx.

encode/httpx#3364

When creating a folder, rdmclient uses the new_folder URL passed from WaterButler. This contains the kind=folder parameter, and the folder is created by passing name=folder name in addition to this parameter.
This is a behavior that expects httpx to combine the query parameters given in the url argument with the query parameters given in params, but the above pull request has changed it to use only params.

This pull request will add support for the new behavior of httpx.

Note that this problem can be temporarily avoided by downgrading httpx.

pip install httpx==0.27.0

@yacchin1205 yacchin1205 marked this pull request as ready for review December 18, 2024 01:17
@yacchin1205 yacchin1205 requested a review from ikfj December 18, 2024 01:22
@ikfj ikfj merged commit d9d2b79 into RCOSDP:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants