[GRDM-48126] Add support for httpx>=0.28.0 #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating folders becomes creating empty files when used with httpx >= 0.28.0 due to the following changes to httpx.
encode/httpx#3364
When creating a folder, rdmclient uses the new_folder URL passed from WaterButler. This contains the
kind=folder
parameter, and the folder is created by passingname=folder
name in addition to this parameter.This is a behavior that expects httpx to combine the query parameters given in the url argument with the query parameters given in params, but the above pull request has changed it to use only params.
This pull request will add support for the new behavior of httpx.
Note that this problem can be temporarily avoided by downgrading httpx.