Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/S check #3

Closed
teknogeek opened this issue Dec 28, 2017 · 5 comments
Closed

Add HTTP/S check #3

teknogeek opened this issue Dec 28, 2017 · 5 comments
Assignees
Milestone

Comments

@teknogeek
Copy link
Contributor

teknogeek commented Dec 28, 2017

There needs to be a check for HTTP and HTTPS services. This check should fetch or load the webpage through requests or selenium in order to ensure that everything is functioning correctly. For verification, this may be done via hashing the entire page contents.

@teknogeek teknogeek changed the title Add HTTP check Add HTTP/S check Dec 28, 2017
@nmpiazza
Copy link
Contributor

Should we split this into 2 different checks, one for HTTP and one for HTTPS. The HTTPS check would check the content of the page, but would also check that TLS is enabled. Also, the TLS check could verify that a specific cert is being used.

@teknogeek
Copy link
Contributor Author

Yeah, sorry there wasn't clarification on this. These should be separate, I just didn't feel a need to separate them into separate issues

@nmpiazza
Copy link
Contributor

nmpiazza commented Dec 31, 2017

The argument for keeping them together is that it limits code duplication by adding the TLS checks as an option. As long as the check verification system can handle different parameters to multiple instances of the same check, we should be fine, right?

@nmpiazza nmpiazza self-assigned this Dec 31, 2017
@teknogeek
Copy link
Contributor Author

Yeah, I think that putting them together is fine. Check out how I did it in the IMAP check: https://github.com/nmpiazza/Hermes/blob/master/app/mod_check/IMAP.py

@nmpiazza nmpiazza added this to the 0.1 milestone Jan 1, 2018
@BrandonGDossantos
Copy link
Collaborator

HTTP/S Check pushed to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants