-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP/S check #3
Comments
Should we split this into 2 different checks, one for HTTP and one for HTTPS. The HTTPS check would check the content of the page, but would also check that TLS is enabled. Also, the TLS check could verify that a specific cert is being used. |
Yeah, sorry there wasn't clarification on this. These should be separate, I just didn't feel a need to separate them into separate issues |
The argument for keeping them together is that it limits code duplication by adding the TLS checks as an option. As long as the check verification system can handle different parameters to multiple instances of the same check, we should be fine, right? |
Yeah, I think that putting them together is fine. Check out how I did it in the IMAP check: https://github.com/nmpiazza/Hermes/blob/master/app/mod_check/IMAP.py |
HTTP/S Check pushed to master. |
There needs to be a check for HTTP and HTTPS services. This check should fetch or load the webpage through
requests
orselenium
in order to ensure that everything is functioning correctly. For verification, this may be done via hashing the entire page contents.The text was updated successfully, but these errors were encountered: