Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved important bits into package for importability #16

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ajcollins0
Copy link
Contributor

  • Moved the scanning bits into a package so it can be imported by others.
  • Added comments for anything exported from the tscanner package.
  • Made variables that are not needed to be exported private.
  • Added a verbose arg to the Scan function that will state the listening address/port if the caller needs.

I am building stuff on top of this scanner and if this logic was inside a package it will allow me (and others) to import this logic rather than fork this repo and edit things as needed. I called the package "tscanner" because "scanner" is already a part of the std lib. Thank you for the work you've done on this and I hope all is well! 🚀 🎄 🎅

@TrueSkrillor TrueSkrillor merged commit 12add8a into RUB-NDS:main Dec 22, 2023
@TrueSkrillor
Copy link
Contributor

Thanks for coming up with this PR! While the original idea of the scanner was to be a simple console application, making it importable doesn't seem to be a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants