Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Spotify "remove screen capture restriction" doesn't patch properly #2377

Closed
3 of 4 tasks
YurKa336 opened this issue Jan 1, 2025 · 3 comments
Closed
3 of 4 tasks
Labels
Bug report Something isn't working

Comments

@YurKa336
Copy link

YurKa336 commented Jan 1, 2025

Bug description

Errors appear when trying to patch the application
Image

Version of ReVanced Manager and version & name of app you are patching

ReVanced Manager version: 1.23.2
Spotify version: 8.9.98.488

Installation method

None

ReVanced Manager logs

...

Patch logs

- Device Info
ReVanced Manager: 1.23.2
Model: SM-S711B
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.spotify.music v8.9.98.488 (Suggested: Any)
Patches version: v5.8.0
Patches added: Remove screen capture restriction
Patches removed: Custom theme, Premium navbar tab
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: true
Patches source: revanced/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Remove screen capture restriction failed: app.revanced.patcher.patch.PatchException: Extension "extensions/all/misc/screencapture/remove-screen-capture-restriction.rve" not found
	at app.revanced.patches.all.misc.screencapture.RemoveScreenCaptureRestrictionPatchKt$removeScreenCaptureRestrictionPatch$lambda$5$$inlined$extendWith$2.get(Patch.kt:404)
	at app.revanced.patches.all.misc.screencapture.RemoveScreenCaptureRestrictionPatchKt$removeScreenCaptureRestrictionPatch$lambda$5$$inlined$extendWith$2.get(Patch.kt:403)
	at app.revanced.patcher.patch.BytecodePatchContext.mergeExtension$revanced_patcher(SourceFile:69)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:158)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:319)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:104)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:277)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:48)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:313)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$_NYn7P0Ss3RCL0-SqEFL-opMsQw(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Compiling modified resources
Aligning APK
Signing APK
Patched APK

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager.
@YurKa336 YurKa336 added the Bug report Something isn't working label Jan 1, 2025
@KeksNino
Copy link

KeksNino commented Jan 2, 2025

i have the same issue since the new update

@cyberboh
Copy link

cyberboh commented Jan 2, 2025

Patches issue ReVanced/revanced-patches#4058
Not a manager issue

@validcube
Copy link
Member

👋 Hello, @YurKa336!

Thanks for filing this issue, but however this issue is out-of-scope for this repository (ReVanced Manager), the correct repository to file this issue in would be our ReVanced Patches repository.

But as @cyberboh pointed out, this issue has already been filed (see ReVanced/revanced-patches#4058), so there's no need to do anything.

Your issue has been updated with a new list of acknowledgement(s) that haven't been met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants