Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test 'tooltip with delay show' inconsistent snapshot #1080

Closed
gabrieljablonski opened this issue Aug 3, 2023 · 2 comments · Fixed by #1171
Closed

[BUG] Test 'tooltip with delay show' inconsistent snapshot #1080

gabrieljablonski opened this issue Aug 3, 2023 · 2 comments · Fixed by #1171
Labels
Bug V6 It might get fixed/merged before, but most likely only on V6's release.

Comments

@gabrieljablonski
Copy link
Member

Managed to reproduce locally the problem with the workflow sometimes failing, and passing on re-run, though this time it is happening with the newer react-tooltip__show class.

https://github.com/ReactTooltip/react-tooltip/blob/master/src/test/tooltip-props.spec.js#L118-L144

https://github.com/ReactTooltip/react-tooltip/blob/master/src/test/__snapshots__/tooltip-props.spec.js.snap#L86

The snapshot switches between having and not having react-tooltip__show. I believe this is likely because we're not using waitFor() correctly to account for the delayShow timer.

@victorpavlenko
Copy link

what about __disappear?

Copy link

github-actions bot commented Dec 1, 2023

This issue is stale because it has not seen activity in 30 days. Remove the stale label or comment within 14 days, or it will be closed.

@github-actions github-actions bot added the Stale This has not seen activity in quite some time label Dec 1, 2023
@gabrieljablonski gabrieljablonski added V6 It might get fixed/merged before, but most likely only on V6's release. and removed Stale This has not seen activity in quite some time labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug V6 It might get fixed/merged before, but most likely only on V6's release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants