fix(subscriptions): unsubscribe correctly when a Subscriber throws during synchronous dispatch. #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
force-pushed
the
unsubscribe-on-sync-throws
branch
from
5bc1b64 to
71cb990
Compare
| } | ||
|
|
||
| public syncErrorValue: any = null; | ||
| public syncErrorThrown: boolean = false; | ||
| public syncErrorThrowable: boolean = true; |
There was a problem hiding this comment.
Do these need to be public or can they be protected?
trxcllnt
force-pushed
the
unsubscribe-on-sync-throws
branch
2 times, most recently
from
b5e781a to
6130382
Compare
trxcllnt
force-pushed
the
unsubscribe-on-sync-throws
branch
2 times, most recently
from
f96b0f2 to
10ab9ed
Compare
…ring synchronous dispatch.
trxcllnt
force-pushed
the
unsubscribe-on-sync-throws
branch
from
10ab9ed to
c4acd2d
Compare
|
@Blesh updated this PR |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1186. Also adds more tests ensuring calls to
next,error, andcompleteare called in the context of whatever Observer they were specified from (theSafeSubscriberin the case of callbacks, or the Object instance if given a duck-typed Observer).