Fix leaks when unsubscribe functions error #1258

benlesh · 2016-01-27T20:46:17Z

Relates to discussion in #1256

Basically this adds a context that is passed around internally that collects all errors and throws them as a group in an UnsubscriptionError when the subscription tree is unsubscribed completely.

trxcllnt · 2016-01-27T20:49:51Z

@Blesh I'm all for this PR, but I think if we're going to have special error handling logic to avoid potential memory leaks here, we should be consistent and do it for subscription as well (#1191).

- adds a test for the issue related #1256

… unsubscribed subscription - tries to synchronously add a custom subscription that throws when unsubscribed to a Subscription that is mid-unsubscribe and therefor flagged `isUnsubscribed`. It's an edge-case, but it should work. fixes #1256

trxcllnt · 2016-01-27T21:19:07Z

src/Subscription.ts

-          subscription.unsubscribe();
+        const sub = _subscriptions[index];
+        if (isObject(sub)) {
+          let trial = tryCatch(sub.unsubscribe).call(sub);


@Blesh is there a reason this is let trial instead of const trial? same for above

Nope. Sorry I missed this comment in my zeal to merge.

benlesh · 2016-01-28T07:22:11Z

@trxcllnt no doubt, I'm just waiting for a rehash of that PR, since I think a lot has changed around that code since you made the PR.

lock · 2018-06-07T02:42:11Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

benlesh added 3 commits January 27, 2016 13:02

fix(Subscription): fix leaks caused by unsubscribe functions that throw

9e88c2e

- adds a test for the issue related #1256

style(Subscription): fix spacing

4ebb88c

trxcllnt reviewed Jan 27, 2016
View reviewed changes

benlesh merged commit 9d5a01c into ReactiveX:master Jan 27, 2016

benlesh deleted the leak-fix branch April 27, 2016 17:15

lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix leaks when unsubscribe functions error #1258

Fix leaks when unsubscribe functions error #1258

benlesh commented Jan 27, 2016

trxcllnt commented Jan 27, 2016

trxcllnt Jan 27, 2016

benlesh Jan 28, 2016

benlesh commented Jan 28, 2016

lock bot commented Jun 7, 2018

Fix leaks when unsubscribe functions error #1258

Fix leaks when unsubscribe functions error #1258

Conversation

benlesh commented Jan 27, 2016

trxcllnt commented Jan 27, 2016

trxcllnt Jan 27, 2016

Choose a reason for hiding this comment

benlesh Jan 28, 2016

Choose a reason for hiding this comment

benlesh commented Jan 28, 2016

lock bot commented Jun 7, 2018