Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Icon page update #1870

Closed
marionnegp opened this issue Sep 16, 2024 · 0 comments · Fixed by #1880
Closed

[docs] Icon page update #1870

marionnegp opened this issue Sep 16, 2024 · 0 comments · Fixed by #1880
Assignees
Labels
docs Improvements or additions to documentation

Comments

@marionnegp
Copy link
Collaborator

Description

This is an update to the formatting and copy for the Icon page made in #1844.

What do you think about using this layout? It keeps the icons pretty dense, but using link button without the icon inside the button helps with scanning imo. I also bumped up the size of the icons to make them easier to see.

Other changes:

  • I think this should be added to the "Foundations" section. I'm not sure this warrants being a top-level page, and PatternFly also has an "Icons" page under their "Design foundations" section.
  • Added an "Overview" section with info about how to use the buttons on the page and links to <rh-icon> docs.
  • Removed copy under each section heading. I'd like to avoid having to update usage info on two different pages.
  • Added cross links that most of our pages have at the bottom.

Links

No response

Screenshots

No response

Additional context

@bennypowers, feel free to unassign yourself if you have too much on your plate! I only added you because you made the original version.

@markcaron @hellogreg, I added this to the Clefairy milestone to update what's already been merged to staging/clefairy.

@marionnegp marionnegp added the docs Improvements or additions to documentation label Sep 16, 2024
@marionnegp marionnegp linked a pull request Sep 18, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

2 participants