-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: theme tokens #138
feat: theme tokens #138
Conversation
🦋 Changeset detectedLatest commit: 6a41135 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-tokens ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6a60ca7
to
92cf1ea
Compare
92cf1ea
to
ee3a56b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also implement icon status tokens from #127. edit: done
@bennypowers, if you're looking to change up some of the more difficult-to-theme token names, @coreyvickery had some ideas in this Red Hat Color Usage Reference spreadsheet. Check out the interactive tokens section, which should help with the theming and would get rid of |
@bennypowers It is now, but with your recent Slack message, I think this can be the last thing the designers work with in that spreadsheet until we all figure out how to work in the repo like you want us to. |
ok @coreyvickery and @marionnegp I think this is ready for review. Please carefully check the deploy preview, especially the colour tokens, and make sure everything's correct. it would be really nice to get some more prose on the status tokens and what they mean, too - i tried my best but i'm not sure i really captured the idea |
@marionnegp @coreyvickery so i think i'll merge this tomorrow and cut a prerelease so we can test this in RHDS. We'll still be able to make any changes we need before officially releasing 2.1 |
Added theme tokens, for responsive theming.
IMPORTANT!
👉 PLEASE SEE RedHat-UX/red-hat-design-system#1792 👈
Notes to reviewers
Let's give a think about the new token names. for things like
--rh-color-border-subtle
, it's easy to just chop of the-on-light|dark
suffix, but for--rh-color-interactive-blue|purple-lighest|darkest
etc, I had to get a bit creative:TODO