Serving penalty: Improve integration

[medrimonia]

Currently, when players finish to serve their penalty, the messages sent to the robots are valid.
However, the robot is still considered has having a penalty internally. This results in weird fixes (see use clearPenaltiesServed in Goal.java) to obtain satisfying behavior.

I have tried to improve the integration a while ago but without success.

[MaikePaetzel]

I'm not entirely sure what you would like to achieve. Do you refer to the behavior that the robot is still penalized even though the penalty time is officially over and then starts blinking yellow and the penalty is only cleared when you click the button in the GameController?

[medrimonia]

I have no idea about it anymore and maybe the code around it has changed, I will try to take a look at it when I'll have more time again.

[MaikePaetzel]

I can confirm that this is a bug with potential side effects that need investigation. The bug can be seen when adding a logging of the player.penalty in AdvancedData line 240 -- while this is supposed to clear the penalty state after the penalty was over, this is not permanent - in fact, the player.penalty gets reset to the current penalty. For some reason this does not affect the data that is sent via the GameState, which is very odd since this is supposed to be the same object that is read from.

This should definitely be investigated as the side effects of this are unclear.