Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: .on() no longer returns instance, breaking api #59

Closed
bkw opened this issue Mar 23, 2018 · 2 comments
Closed

Heads up: .on() no longer returns instance, breaking api #59

bkw opened this issue Mar 23, 2018 · 2 comments
Labels

Comments

@bkw
Copy link

bkw commented Mar 23, 2018

Just a quick heads up that somewhere between 2.1.0 and 2.2.1 the api was changed so that calls to bottleneck.on() no longer return the bottleneck instance and thus are no longer chainable.

Maybe not a biggie, but probably still worth a mention in the release notes since (for us) this was a breaking change and makes bottlenecks behavior now differ from node's events.EventEmitter.on().

@bkw bkw changed the title Head up: .on() no longer returns instance, breaking api Heads up: .on() no longer returns instance, breaking api Mar 23, 2018
@SGrondin SGrondin added the bug label Mar 23, 2018
@SGrondin
Copy link
Owner

Thanks for the bug report, it will be fixed in 2.2.2

@SGrondin
Copy link
Owner

2.2.2 has been released, which includes a fix for this issue. Thank you for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants