-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using a separate python package to manage Julia dependency #99
Comments
Yes, those are major issues I've been hoping to solve!!! Automated installation and #56. I would absolutely love to see a PR on this. I think it will greatly improve the library. Would you be willing to do the PR? |
I can probably find time over the next few weeks to make a PR that's a little more polished than the proof of concept that I posted above. But, I'd probably need help on the fine points of python packaging, e.g. setup.cfg, making sure CI works, etc. |
Yeah, no worries. I will find the time, and hopefully @tkf could help. |
I just tested this and found this issue. jlapeyre/diffeq_julia#1 |
A couple of problems turned up in that issue, both because I made some changes to The main goal of |
@sibyjackgrove helped to debug https://github.com/jlapeyre/diffeq_julia . The package depends on https://github.com/jlapeyre/julia_project, which factors out managing a Julia project within a python package. The latter depends in turn on https://github.com/jlapeyre/find_julia, which handles finding a path to a Julia exectuable, and if not found installing Julia via jill.py. The directory with the system-image-compilation scripts is here:
EDIT: I think this should perhaps get a bit more testing in the wild before a PR is made to diffeqpy. The tests in julia_project and find_julia are minimal at best. Testing properly would require a lot of mocking of the state of your system. i.e. if and where julia is installed. If PyCall is installed, how it is built, etc. All the debugging was around these issues. |
I added a |
This is now handled by PythonCall. |
Here is a quick example:
https://github.com/jlapeyre/diffeq_julia
This handles installing Julia and Julia packages. It allows optionally compiling a system image particular to the diffeq project.
The text was updated successfully, but these errors were encountered: