Fix py310 test #207
Fix py310 test #207
Conversation
|
BTW, I'm not able to build latest release or main with modern pip/setuptools. I'm not sure what changed but I can only build the release before 3.0.1.post0. See conda-forge/cf_units-feedstock#45 |
Our Read the Docs builds show that this first occurred at commit 5540e08. |
ocefpaf
force-pushed
the
fix_py310_test
branch
from
723a85b to
dea3b26
Compare
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 6 6
Lines 816 816
Branches 121 121
=======================================
Hits 743 743
Misses 61 61
Partials 12 12 Continue to review full report at Codecov.
|
requirements/py38.yml
Outdated
| @@ -12,7 +12,7 @@ dependencies: | |||
|
|
|||
| # core dependencies | |||
| - antlr-python-runtime 4.7.2.* | |||
| - cftime>=1.2 | |||
| - cftime>=1.2,<1.5.1.1 | |||
There was a problem hiding this comment.
We probably don't want this pin but I'm not sure what is the right fix for cftime new default. Should I just change the expected calendar in that test? If so, the test is a bit flaky and ensuring the expected calendar explicitly is probably better than relaying on cftime's defaults.
There was a problem hiding this comment.
Over at #205, @larsbarring actively wants to change the expected calendar in that test. But now I’m confused, as I thought Unidata/cftime#257 would be needed to change it, and cftime‘s GitHub page is not indicating any releases since September 😕
There was a problem hiding this comment.
I was in contact with cftime developers in Unidata/cdtime#256 and initially they did a required change in Unidata/cdtime#257. But it it broke xarray, and thus was not merged into main. So I asked the xarray devs and they have some ideas. But I am already way out of my competence zone, so I will just have to wait see --- and hope that I have not caused any trouble for you guys.
There was a problem hiding this comment.
hope that I have not caused any trouble for you guys.
Not at all, I think by opening #205 you have helped us prepare for this change whereas usually we catch up some time later.
I am just confused because there seems to be a new cftime release that is not advertised on their GitHub page (which is where I had been checking).
There was a problem hiding this comment.
@rcomer maybe we can take the conservative approach for now and issue one more release with a cftime pin to unlock a py310 wheel?
|
Python 3.10 is failing now b/c we are missing the older cftime on that py version. I added it to conda-forge and this test should pass when we restart. However, we should probably just update the test to the latest cftime and pin to cftime>1.5.1.1 instead. What do you all think? |
|
Replaced by #214 |
I'm not sure how to set cirrus-ci and if I added the new env file correctly. I'm not familiar with this multiple files setup. Hopefully things are in the right place.