Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: shopify theme dev stops after an hour and a half #781

Closed
2 tasks done
diegovogel opened this issue Nov 17, 2022 · 9 comments · Fixed by #927
Closed
2 tasks done

[Bug]: shopify theme dev stops after an hour and a half #781

diegovogel opened this issue Nov 17, 2022 · 9 comments · Fixed by #927
Assignees
Labels
Area: @shopify/cli-kit @shopify/cli-kit package issues Area: @shopify/theme @shopify/theme package issues no-issue-activity Severity: 3 Normal Severity State: Assigned to team Internal team aware of issue and now responsible for updates Type: Bug Something isn't working

Comments

@diegovogel
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

When I run shopify theme dev I expect it to run as long as my computer is awake.

Actual behavior

When I run shopify theme dev it will only run for about an hour and a half before stopping. And when I restart it I always have to log back in. I'm assuming the theme dev command stops because I'm getting automatically logged out. I'm not sure if this is a bug or a feature but it's annoying.

Stack trace

No response

Reproduction steps

  1. Run shopify theme dev.
  2. Wait about an hour and a half for it to stop.

Operating System

macOS Ventura

Shopify CLI version (check your project's package.json if you're not sure)

3.23.0

Shell

zsh

Node version (run node -v if you're not sure)

v15.14.0

What language and version are you using in your application?

No response

@diegovogel diegovogel added the Type: Bug Something isn't working label Nov 17, 2022
@isaacroldan
Copy link
Contributor

Hi @diegovogel, thanks for reporting this. It is a known bug and we are working on fixing it

@isaacroldan isaacroldan added Area: @shopify/cli-kit @shopify/cli-kit package issues Area: @shopify/theme @shopify/theme package issues State: Assigned to team Internal team aware of issue and now responsible for updates Severity: 3 Normal Severity labels Nov 17, 2022
@diegovogel
Copy link
Author

Great, thanks @isaacroldan

@habibly
Copy link

habibly commented Nov 18, 2022

@diegovogel I also faced similar issues, what worked for me is changing cli version, there is a slight difference of cli commands between version 2 and 3 so you'll have to keep that in check.

  • For theme development use shopify cli 2.x as recommended here
  • If you need help you can check these instructions on Shopify Cli 2.x here

@diegovogel
Copy link
Author

diegovogel commented Nov 18, 2022

Thanks @habibly. We recently upgraded from 2.x to 3.x because the docs seem to encourage that. But I see what you're saying about the repo suggesting otherwise. @isaacroldan can you clarify what should be used for theme dev?

There are other benefits of 3.x that we're enjoying, so we may stick with it anyway.

@isaacroldan
Copy link
Contributor

Yes, CLI 3.x is the recommended tool for themes. We are actively working on solving this and other theme issues, i'll update this issue when we have a fix.

That message from the CLI 2.x repo is outdated, i'll make sure we update that doc soon.

@notrealdev
Copy link

same here, stops after an hour and a half
need more time pls.

@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@notrealdev
Copy link

There a timeset called ThemeRefreshTimeoutInMinutes in the Shopify auth using the CLI to authenticate to a store, its 90 minutes, this really need to change as soon as possible or add the --password flag to use the token generated by the theme Access App.

Check here: https://github.com/Shopify/cli/blob/main/packages/theme/src/cli/commands/theme/dev.ts

@diegovogel
Copy link
Author

Just updated to v3.28.0 and it's fixed! After 2 hrs I'm still logged in. Thank you @isaacroldan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/cli-kit @shopify/cli-kit package issues Area: @shopify/theme @shopify/theme package issues no-issue-activity Severity: 3 Normal Severity State: Assigned to team Internal team aware of issue and now responsible for updates Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants