Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON syntax in adding-docs-guide.md #26

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fix JSON syntax in adding-docs-guide.md #26

merged 2 commits into from
Mar 15, 2023

Conversation

joshmue
Copy link
Contributor

@joshmue joshmue commented Mar 15, 2023

Remove problematic ,; Add necessary ".

@joshmue
Fix JSON in adding-docs-guide.md
bbd55f3 
Signed-off-by: Joshua Mühlfort <[email protected]>
@joshmue joshmue requested a review from maxwolfs March 15, 2023 10:18
maxwolfs
maxwolfs approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@maxwolfs maxwolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@maxwolfs
fix link
6ecb5f9 
Signed-off-by: Max Wolfs <[email protected]>
@maxwolfs maxwolfs merged commit b845290 into main Mar 15, 2023
@maxwolfs maxwolfs deleted the joshmue-patch-1 branch March 15, 2023 10:33
garloff pushed a commit that referenced this pull request Aug 28, 2023
@maxwolfs @itrich
Add PAT to synchronize docs workflow (#26)
25223bd 
* Run checkout with explicit PAT
* Use correct secrets notation

---------

Signed-off-by: Eduard Itrich <[email protected]>
Co-authored-by: Eduard Itrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwolfs maxwolfs maxwolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmue @maxwolfs