Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmanip #11

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Bitmanip #11

merged 6 commits into from
Apr 2, 2024

Conversation

andreasWallner
Copy link
Collaborator

This should be an initial version thats mergeable, but not fully done yet.

Current TODO list that I'd open as an issue:

  • Push changes to NaxSoftware so that we can have proper benchmarks - I'd not go for full combinatorics here, that would explode the number of images that we need, also needs a few changes in the regression (also the reason why I'm not yet adding the arch flags)
  • optimize the current ZbbCountPlugin, the comb path should be horrific ATM
  • possibly make the current situation with ZbPlugin.make cleaner, though not sure how... Zbb should not be a single plugin IMO

@Dolu1990
Copy link
Member

Dolu1990 commented Apr 2, 2024

Soooo many plugins <3

I sent you rights to the NaxSoftware repo.
Feel free to merge :)

Thanks :D

@Dolu1990
Copy link
Member

Dolu1990 commented Apr 2, 2024

I'd not go for full combinatorics here

Right ^^

So, fondamentaly, as long as there is no coupling between sub parts of the extension, i would say no need to handle them separatly in the binaries.

@andreasWallner andreasWallner merged commit 5446468 into dev Apr 2, 2024
2 checks passed
@andreasWallner andreasWallner deleted the bitmanip branch April 2, 2024 14:08
@andreasWallner
Copy link
Collaborator Author

In the number of plugins: I kept them separate where there is no real reuse of hardware, so that a plugin is useful on its own and there is no big overlap...

On the combinatorics: to some degree there is overlap in the benchmarks...

@Dolu1990
Copy link
Member

Dolu1990 commented Apr 2, 2024

On the combinatorics: to some degree there is overlap in the benchmarks...

Right XD
I would say, let's keep full B extentions for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants