Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for BlackBoxBoundedContext #1250

Closed
8 tasks done
alexander-yevsyukov opened this issue Mar 16, 2020 · 2 comments
Closed
8 tasks done

Improvements for BlackBoxBoundedContext #1250

alexander-yevsyukov opened this issue Mar 16, 2020 · 2 comments
Assignees

Comments

@alexander-yevsyukov
Copy link
Contributor

alexander-yevsyukov commented Mar 16, 2020

  • Do not descend BlackBoxBoundedContext from AbstractEventSubscriber. This adds unnecessary public API to the class, which is confusing for the user. Have a package-private class which does all the job instead.

  • Deprecate all the factory methods, leaving only from()

  • Remove deprecated API.

  • Why do we want to expose SingleTenantBlackBoxContext and MultiTenantBlackBoxContext as separate types? Can we keep the package-private? It would improve debugging, but having isMultitenant() is quite enough for the public API. After all we want to make the tenancy aspect hidden from the users as much as possible. Let's be consistent.

  • Remove generic parameter of BlackBoxContext.

  • Remove test-only methods like eventBus(), commandBus(), stateTypes().

  • Remove withActorIn(UserId userId, ZoneId zoneId, ZoneOffset zoneOffset) method.
    Use combination withActor() and in() methods instead.

  • Remove zoneOffset parameter from in() method.
    Obtain zoneOffset from the passed zoneId.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Mar 16, 2020
@alexander-yevsyukov
Copy link
Contributor Author

alexander-yevsyukov commented Mar 18, 2020

Partially addressed in #1251.

@alexander-yevsyukov
Copy link
Contributor Author

Finalized in #1252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant