Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Optional instead of @Nullable when loading entities #255

Closed
alexander-yevsyukov opened this issue Jan 5, 2017 · 1 comment
Closed

Use Optional instead of @Nullable when loading entities #255

alexander-yevsyukov opened this issue Jan 5, 2017 · 1 comment
Labels
tech debt

Comments

@alexander-yevsyukov
Copy link
Contributor

Repository.load() now returns @Nullable, and then some overriding classes apply @Nonnull, which is a violation of contract defined by the parent class.

Let's use Guava's Optional (and then Java8's in v2) instead.
@alexander-yevsyukov alexander-yevsyukov mentioned this issue Jan 6, 2017
Merged
@alexander-yevsyukov
Copy link
Contributor Author

Fixed by #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexander-yevsyukov