Fix remediated task with retry

[m4dcoder]

Fix issue when a task that has a transition on failure will also traverse the transition on retry. The issue is caused by the recursion on update_task_state. There should be a return in the recursive call.

[codecov-io]

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          41       41           
  Lines        2735     2735           
  Branches      545      545           
=======================================
  Hits         2572     2572           
  Misses        100      100           
  Partials       63       63           

Impacted Files	Coverage Δ
orquesta/conducting.py	93.24% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdb704...36a3475. Read the comment docs.

[amanda11]

looks good. Passed the scenario that caused me to report issue. Re-tested with and without retries and all went fine.

[arm4b]

We'll take it to st2 v3.2.0

@m4dcoder I guess we'll release v1.1.1 orquesta once its merged to include in st2 dependencies?

[m4dcoder]

Yes. I'll do a release of v1.1.1.

[blag]

👍

[soumyabk]

we're using the stackstorm-ha to deploy our cluster (https://github.com/StackStorm/stackstorm-ha) - once this is merged, how do we pick up the change?

[blag]

@soumyabk
We are working on releasing ST2 version 3.2 next week. That version will automatically include an up-to-date version of Orquesta that includes this change. You can pick up this change by installing that version once it is officially released.

[arm4b]

It's a bit different in stackstorm-ha Helm chart context.

@soumyabk Because stackstorm-ha is in beta state it already relies on most recent 3.2dev version meaning it gets latest updates from the master.
See https://github.com/StackStorm/stackstorm-ha/blob/master/Chart.yaml#L3

We'll need to get this patch merged and then include into st2. Automation will get all the packages ready, generate & deploy Docker images and so on.
I think you should see the fix in 1-2 days rolled out in your environment. Please follow-up if not.