Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if element and cancelOnUserAction passed the whole page can't scroll #28

Closed
DavidNeiOs opened this issue Sep 13, 2019 · 3 comments
Closed

if element and cancelOnUserAction passed the whole page can't scroll #28

DavidNeiOs opened this issue Sep 13, 2019 · 3 comments

Comments

@DavidNeiOs
Copy link
Contributor

Hello,
I had this issue while working with the library, I pass an horizontal element to be animated and also cancelOnUserAction: false but the whole page loses the scroll behaviour.

I fixed it by changing the window listeners of wheel, scroll and touch start to options.element

Screen Shot 2019-09-13 at 7 45 32 PM
@Stanko
Copy link
Owner

Stanko commented Sep 14, 2019

Hello @DavidNeiOs,
Good catch, can you please open a PR with changes?
Thank you!

@DavidNeiOs DavidNeiOs mentioned this issue Sep 14, 2019
Merged
@DavidNeiOs
Copy link
Contributor Author

@Stanko PR made :)

@Stanko
Copy link
Owner

Stanko commented Sep 14, 2019

Published in 1.3.1 🎉
Thank you for help!

@Stanko Stanko closed this as completed Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stanko @DavidNeiOs