Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): fully remove parts of non-global redis #537

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

olevski
Copy link
Member

@olevski olevski commented Feb 8, 2022

So these call-nested helpers were meant (through some witchery) to call the template of a requirement/child helm chart and pull out the redis release name which is then used in the label to allow client applications to connect to redis.

Now since we rely on a global redis instance we should not use this anymore. There is no local redis anymore.

This was causing the helm chart building/publishing step to fail: https://github.com/SwissDataScienceCenter/renku-gateway/runs/5108179637?check_suite_focus=true

/deploy #persist

@olevski olevski requested a review from ableuler February 8, 2022 17:44
@olevski olevski requested a review from a team as a code owner February 8, 2022 17:44
@olevski
Copy link
Member Author

olevski commented Feb 8, 2022

In addition to the issue with the values extracted from child charts, I also did the following:

  • cleaned up the messy defaults/required stuff around the secrets, now the secrets have dummy defaults with comments that indicate that they should be set to proper values for prod
  • enabled the tests for the helm chart for every PR

@olevski
Copy link
Member Author

olevski commented Feb 8, 2022

... also we should probably not use helm v2 to test the chart.

Panaetius
Panaetius previously approved these changes Feb 9, 2022
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@olevski olevski temporarily deployed to renku-ci-gw-537 February 9, 2022 09:39 Inactive
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative of cleaning things up. There's still a few things that we need to figure out though.

@ableuler
Copy link
Contributor

ableuler commented Feb 9, 2022

... also we should probably not use helm v2 to test the chart.

🙈

@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 9, 2022

You can access the deployment of this PR at https://renku-ci-gw-537.dev.renku.ch

@olevski olevski temporarily deployed to renku-ci-gw-537 February 9, 2022 10:06 Inactive
@olevski olevski temporarily deployed to renku-ci-gw-537 February 9, 2022 10:15 Inactive
@olevski olevski requested a review from ableuler February 9, 2022 10:16
@olevski olevski force-pushed the fix-global-redis-helm-chart-changes branch from 07f4763 to 3151831 Compare February 9, 2022 12:55
@olevski olevski temporarily deployed to renku-ci-gw-537 February 9, 2022 13:20 Inactive
@olevski
Copy link
Member Author

olevski commented Feb 9, 2022

@ableuler this is ready now.

@olevski olevski temporarily deployed to renku-ci-gw-537 February 9, 2022 14:28 Inactive
@olevski olevski deployed to renku-ci-gw-537 February 9, 2022 14:57 Active
@olevski olevski merged commit 9003029 into master Feb 9, 2022
@olevski olevski deleted the fix-global-redis-helm-chart-changes branch February 9, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants