-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): fully remove parts of non-global redis #537
Conversation
In addition to the issue with the values extracted from child charts, I also did the following:
|
... also we should probably not use helm v2 to test the chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initiative of cleaning things up. There's still a few things that we need to figure out though.
🙈 |
You can access the deployment of this PR at https://renku-ci-gw-537.dev.renku.ch |
07f4763
to
3151831
Compare
@ableuler this is ready now. |
So these
call-nested
helpers were meant (through some witchery) to call the template of a requirement/child helm chart and pull out the redis release name which is then used in the label to allow client applications to connect to redis.Now since we rely on a global redis instance we should not use this anymore. There is no local redis anymore.
This was causing the helm chart building/publishing step to fail: https://github.com/SwissDataScienceCenter/renku-gateway/runs/5108179637?check_suite_focus=true
/deploy #persist