fix(chart): whitespace in helm templating #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also TIL that "comments" in .tpl helpers that just start with |
ableuler
approved these changes
Feb 10, 2022
|
You can access the deployment of this PR at https://renku-ci-gw-544.dev.renku.ch |
|
The only acceptance test that is failing is the dataset text search. But this PR does not affect that functionality at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.12.1 cleaned up some of the helm chart templating but also unfortunately introduced a few bugs.
Not sure how the CI deployments in the PR that introduced these changes did not see this at all. I think that maybe there was an old pod that was successfully running and the new ones could never start to replace it so everything looked good.
/deploy #persist