Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): detailed status messages #1289

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 26, 2022

closes #1135

Provides more detailed information about server status.

Example status section of server response:

                         "status": {
				"details": [{  # NEW
					"status": "ready",
					"step": "Initialization"
				}, {
					"status": "ready",
					"step": "Downloading session image"
				}, {
					"status": "executing",
					"step": "Cloning and configuring the repository"
				}, {
					"status": "waiting",
					"step": "Git credentials services"
				}, {
					"status": "waiting",
					"step": "Authentication and proxying services"
				}, {
					"status": "waiting",
					"step": "Auxiliary session services"
				}, {
					"status": "waiting",
					"step": "Starting session"
				}],
				"message": "Containers with non-ready statuses: git-proxy, git-sidecar, jupyter-server, oauth2-proxy.",
				"readyNumContainers": 2,  # NEW
				"state": "starting",
				"totalNumContainers": 7  # NEW
			},

Possible step states:

  • ready
  • executing
  • waiting
  • failed

Because of how containers react in k8s I modified the terminology a little bit. A container can be ready if it completes with 0 exit code or if it run and it passes all its probes. When all containers (i.e. steps) are ready then the whole session is ready. But the definitive flag on when the session can be accessed and is 100% ready is the status.state value. The status.state value will even check if the URL is reachable before turning to "running".

/deploy #persist

@olevski olevski requested a review from a team as a code owner September 26, 2022 21:40
@olevski olevski temporarily deployed to renku-ci-nb-1289 September 26, 2022 21:40 Inactive
@olevski
Copy link
Member Author

olevski commented Sep 26, 2022

@ciyer @andre-code You can test against the CI deployment. Let me know what you think.

@olevski olevski marked this pull request as draft September 26, 2022 21:41
@olevski
Copy link
Member Author

olevski commented Sep 26, 2022

This is a draft because I want to make sure any changes from the ui side are addressed before someone reviews.

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1289.dev.renku.ch

@andre-code
Copy link
Contributor

andre-code commented Oct 3, 2022

@ciyer @andre-code You can test against the CI deployment. Let me know what you think.

Thanks for this implementation @olevski , it works very well 👏, here you can find the UI implementation using this new information.
SwissDataScienceCenter/renku-ui#2054

@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 15:04 Inactive
@olevski olevski force-pushed the feat-detailed-status-message branch from 5540da0 to d45dd43 Compare October 6, 2022 16:59
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 17:00 Inactive
@olevski olevski force-pushed the feat-detailed-status-message branch from d45dd43 to 1c0d936 Compare October 6, 2022 19:35
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 19:35 Inactive
@olevski olevski force-pushed the feat-detailed-status-message branch from 1c0d936 to 6b2a7c2 Compare October 6, 2022 20:58
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 20:58 Inactive
@olevski olevski force-pushed the feat-detailed-status-message branch from 6b2a7c2 to 169ea7e Compare October 6, 2022 21:38
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 21:39 Inactive
@olevski olevski force-pushed the feat-detailed-status-message branch from 169ea7e to a9515a5 Compare October 6, 2022 22:05
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 6, 2022 22:05 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-1289 October 13, 2022 14:35 Inactive
@olevski olevski marked this pull request as ready for review October 13, 2022 14:36
@olevski olevski requested a review from a team as a code owner October 13, 2022 14:36
@olevski olevski deployed to renku-ci-nb-1289 October 14, 2022 11:35 Active
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olevski olevski merged commit 6086585 into master Oct 14, 2022
@olevski olevski deleted the feat-detailed-status-message branch October 14, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update session status to include containers numbers and the steps's status when starting a session
4 participants