Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s operator POC #668

Merged
merged 252 commits into from
Sep 15, 2021
Merged

K8s operator POC #668

merged 252 commits into from
Sep 15, 2021

Conversation

olevski
Copy link
Member

@olevski olevski commented May 28, 2021 •
edited by ableuler
Loading

Depends on the following PRs:

/deploy renku=notebooks-operator-poc

olevski and others added 30 commits May 10, 2021 23:52
@olevski
chore: add tests for checking proper server options defaults are used
73c0533
@olevski
remove size limit for emptyDir
d6f75fa
@olevski
fix: add backup defaults for gpu and disk size in schemas
e1e2106
@olevski
fix: remove defaults assignment to server options in JH spawner
6d43028
@olevski
fix: add disk size limit for emptyDir
77647c7
@olevski
fix: make all server options mandatory in values file for helm chart
8590d6d
@olevski
fix: split server options for UI and for notebooks defaults
e231e6b
@olevski
fix: set empty dictionary for missing ui server options
a45a126
@olevski
squashme: minor fix
47e4859
@olevski
fix: update values yaml instructions on ephemeral storage limits
a9d2356
@olevski
squashme: fix tests
2909827
@olevski
fix: split ui server options and default server options schemas and f…
a7ec722 
…ields
@olevski
fix: add default server options to values file
d38b094
@olevski
fix: require at least lfs auto fetch option in UI server options
a98bfe3
@olevski
fix: properly enforce server option defaults when no alternatives are…
b4ef4e5 
… possible in ui server options
@olevski
feat: add autosave classes
d214a26
@olevski
squashme: fixes
976a72a
@olevski
squashme: fixes
2f47199
@olevski
feat: add autosave names to endpoint
614a826
@olevski
squashme: fixes
fc62531
@olevski
squashme: fixes
e3338ea
@olevski
Merge branch 'master' into fix-properly-assign-default-server-option-…
4ced094 
…values
feat: add a git sidecar container
eba6b2a 
This container clones the repo on the entrypoint and exposes a JSON-rpc endpoit to query repo status.
@olevski
squashme: fixes
7c9d343
@olevski
fix: automatically adjust ephemeral storage limits
d0504ec
@olevski
squashme: fixes
0e0ade5
@olevski
squashme: fixes
58e9a8b
@olevski
merge latest changes
d3c138a
@olevski
squashme: remove cull secrets from values file
f267b4e
@olevski
squashme: remove cull secrets from helm chart
90fb984
@olevski olevski temporarily deployed to renku-ci-nb-668 September 13, 2021 23:07 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 13, 2021 23:24 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 14, 2021 00:24 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 14, 2021 09:07 Inactive
ableuler
ableuler suggested changes Sep 14, 2021
View reviewed changes
@olevski olevski temporarily deployed to renku-ci-nb-668 September 14, 2021 16:04 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 14, 2021 16:14 Inactive
@olevski olevski mentioned this pull request Sep 14, 2021
Merged
@olevski olevski temporarily deployed to renku-ci-nb-668 September 15, 2021 08:49 Inactive
@olevski
feat: enable culling sessions (#747)
446bf4e 
* feat: enable automated culling with amalthea
@olevski olevski temporarily deployed to renku-ci-nb-668 September 15, 2021 11:20 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 15, 2021 11:52 Inactive
@olevski olevski temporarily deployed to renku-ci-nb-668 September 15, 2021 13:10 Inactive
ableuler
ableuler approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olevski olevski mentioned this pull request Sep 15, 2021
Closed
@olevski olevski deployed to renku-ci-nb-668 September 15, 2021 15:11 Active
@olevski
Copy link
Member Author

olevski commented Sep 15, 2021

I manually confirmed that the single failed acceptance test is not real:

[info] UnprivilegedEnvironmentSpec:
[info] Scenario: User can launch unprivileged environment - done *** FAILED ***
[info]   The code passed to eventually never returned normally. Attempted 717 times over 2.0022981066666667 minutes. Last failure message: Connect to environment button not found. (ProjectPage.scala:307

As a logged in user I could launch a session from the andi/public-test-project repo without a problem.

@olevski olevski merged commit 5444857 into master Sep 15, 2021
@olevski olevski deleted the k8s-operator-poc branch September 15, 2021 16:10
ableuler pushed a commit that referenced this pull request Sep 15, 2021
@olevski
feat: use Amalthea to run sessions through a K8s operator (#668)
f808ac0 
- refactoring of the notebook service
- adapt existing and expand test suite

Co-authored-by: Andreas Bleuler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ableuler ableuler ableuler approved these changes

@rokroskar rokroskar Awaiting requested review from rokroskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor UserServer class
4 participants
@olevski @rokroskar @RenkuBot @ableuler