Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataset): import renku datasets #1894

Merged
merged 2 commits into from
Feb 23, 2021
Merged

fix(dataset): import renku datasets #1894

merged 2 commits into from
Feb 23, 2021

Conversation

mohammad-alisafaee
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee commented Feb 23, 2021 •
edited
Loading

Description

Make dataset import more resilient to errors. Move files instead of copying to preserve disk space.

Fixes #1741
Fixes #1879

@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review February 23, 2021 10:56
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner February 23, 2021 10:56
Panaetius
Panaetius approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mohammad-alisafaee mohammad-alisafaee merged commit 279407e into master Feb 23, 2021
@mohammad-alisafaee mohammad-alisafaee deleted the 1741-dataset-import-failed branch February 23, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing dataset via URL + dataset ID crashes service dataset import failed
2 participants
@mohammad-alisafaee @Panaetius