Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataset): improve naming for imported datasets #1900

Merged
merged 2 commits into from
Mar 1, 2021
Merged

feat(dataset): improve naming for imported datasets #1900

merged 2 commits into from
Mar 1, 2021

Conversation

mohammad-alisafaee
Copy link
Contributor

Description

Allow more characters in generated names for imported datasets.

Fixes #1698

@mohammad-alisafaee mohammad-alisafaee force-pushed the 1698-better-naming-for-datasets branch from 9aa3780 to 2e34f54 Compare February 25, 2021 14:52
@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review February 25, 2021 17:22
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner February 25, 2021 17:22
Panaetius
Panaetius requested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but I think it makes sense if we define a max length for slugs and never exceed that length (e.g. 25 or 30 characters).

renku/core/models/datasets.py Outdated

return "_".join(name)
version_slug = get_slug(dataset_version)
return f"{slug}_{version_slug}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to use something like slug[:-len(version_slug)] and limit version_slug length to something like 10 to ensure a consistent slug max length?

@mohammad-alisafaee mohammad-alisafaee force-pushed the 1698-better-naming-for-datasets branch 3 times, most recently from e136ba3 to a04c445 Compare February 26, 2021 13:55
@mohammad-alisafaee mohammad-alisafaee force-pushed the 1698-better-naming-for-datasets branch from a04c445 to 35461fd Compare February 26, 2021 15:53
@mohammad-alisafaee mohammad-alisafaee merged commit 9beb654 into master Mar 1, 2021
@mohammad-alisafaee mohammad-alisafaee deleted the 1698-better-naming-for-datasets branch March 1, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better naming for imported datasets
2 participants
@mohammad-alisafaee @Panaetius