Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify values from client and server sections #1976

Closed
lorenzo-cavazzi opened this issue Jul 27, 2022 · 1 comment · Fixed by #1998
Closed

Unify values from client and server sections #1976

lorenzo-cavazzi opened this issue Jul 27, 2022 · 1 comment · Fixed by #1998
Assignees
@ciyer
Milestone
2.9.0

Comments

@lorenzo-cavazzi
Copy link
Member

Motivation

We merged the UI client and server charts in #1942 , but the values file can be harmonized further by moving out from the client and server sections some common values (E.G. ui.client.uiserverUrl is the same of ui.server.serverData.url + ui.server.serverData.prefix )

Proposal

We should identify and remove the duplicates by moving the values to the generic ui section. This requires adjusting the values also in
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Jul 27, 2022
Merged
@lorenzo-cavazzi lorenzo-cavazzi changed the title Unify values from client and server section Unify values from client and server sections Jul 27, 2022
@ciyer ciyer added this to the 2.7.0-next milestone Aug 3, 2022
@ciyer ciyer self-assigned this Aug 11, 2022
@ciyer ciyer modified the milestones: 2.8.0, 2.8.0-next Sep 8, 2022
@ciyer ciyer linked a pull request Sep 22, 2022 that will close this issue
build(chart): remove duplicates in client/server charts #1998
Merged
@ciyer
Copy link
Contributor

ciyer commented Sep 22, 2022

Fixed in #1998

@ciyer ciyer closed this as completed Sep 22, 2022
Repository owner moved this from Todo to Done in UI Sprints - DEPRECATED Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciyer ciyer

Labels
None yet
Projects
No open projects
UI Sprints - DEPRECATED
Status: Done ✅
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

build(chart): remove duplicates in client/server charts SwissDataScienceCenter/renku-ui
2 participants
@ciyer @lorenzo-cavazzi