Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few UI glitches #2017

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Fix a few UI glitches #2017

merged 4 commits into from
Sep 1, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

This PR contains a few fixes. I split them in different commits so that it's easier to review the code changes separately:

  1. The star button displayed an endless spinning wheel for anonymous users. Not it shows the start and it restores the behavior on click (will redirect to the login to continue)
    Screenshot_20220830_161208
  2. Adjust the margins on search containers by reducing margin in equal parts on both left and right sides, instead of left only (in the screenshot, the left screen shows balanced margins, while on the right screen there is a smaller space on the left and a bigger one on the right).
    Screenshot_20220830_161041
  3. Prevents invoking multiple times the projects API with the same parameters when reaching the projects page. This was worse in the case of anonymous users since they were also redirected, adding an extra query for their own projects that always returns empty since they can't have any own projects (in the screenshot, there are 3 queries on the right side, while only 1 on the left).
    Screenshot_20220830_164725
  4. The projects page redirected anonymous users to the public projects page using history.push, therefore preventing any backward navigation.

/deploy renku-gateway=master #persist
fix #2014

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner August 30, 2022 15:06
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2017 August 30, 2022 15:06 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2017.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2017 August 30, 2022 20:43 Inactive
@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2017 August 31, 2022 07:29 Active
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and works as expected!
Thanks for the corrections :)

@lorenzo-cavazzi lorenzo-cavazzi merged commit f674370 into master Sep 1, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 2014-anonuser-glitches branch September 1, 2022 08:40
@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 1, 2022

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 2.8.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues browsing projects as an anonymous user
4 participants