-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose project metadata JSON-LD (#1867) #2022
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2022.dev.renku.ch |
91a871c
to
b558118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well, and I like how you implemented it! 🤩
I found one thing in the code that is unnecessary, I think, but otherwise this looks great.
transformResponse: (response: any) => { | ||
return response; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Looks like it was added for debugging, but the response isn't modified anymore.
b558118
to
daeb560
Compare
@ciyer you are right, it is not necessary. I removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
daeb560
to
c782cc9
Compare
c782cc9
to
8683aab
Compare
8683aab
to
2c2b805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
5f9a110
to
64f2071
Compare
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR to expose metadata from Renku projects as json-ld structured data.
/deploy #persist