Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose project metadata JSON-LD (#1867) #2022

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Sep 2, 2022

PR to expose metadata from Renku projects as json-ld structured data.

/deploy #persist

@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 2, 2022

You can access the deployment of this PR at https://renku-ci-ui-2022.dev.renku.ch

@andre-code andre-code changed the title chore: update package-lock.json feat: Expose project metadata JSON-LD (#1867) Sep 2, 2022
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 2, 2022 13:03 Inactive
@andre-code andre-code force-pushed the 1867-expose-project-metadata-JSON-LD branch from 91a871c to b558118 Compare September 6, 2022 08:00
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 6, 2022 08:00 Inactive
@andre-code andre-code marked this pull request as ready for review September 6, 2022 08:08
@andre-code andre-code requested a review from a team as a code owner September 6, 2022 08:08
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, and I like how you implemented it! 🤩

I found one thing in the code that is unnecessary, I think, but otherwise this looks great.

Comment on lines 30 to 31
transformResponse: (response: any) => {
return response;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Looks like it was added for debugging, but the response isn't modified anymore.

@gavin-k-lee gavin-k-lee linked an issue Sep 8, 2022 that may be closed by this pull request
2 tasks
@andre-code andre-code force-pushed the 1867-expose-project-metadata-JSON-LD branch from b558118 to daeb560 Compare September 8, 2022 11:22
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 8, 2022 11:23 Inactive
@andre-code
Copy link
Contributor Author

This works well, and I like how you implemented it! 🤩

I found one thing in the code that is unnecessary, I think, but otherwise this looks great.

@ciyer you are right, it is not necessary. I removed it.
Thanks for your review 🙌

ciyer
ciyer previously approved these changes Sep 8, 2022
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andre-code andre-code force-pushed the 1867-expose-project-metadata-JSON-LD branch from daeb560 to c782cc9 Compare September 15, 2022 07:25
@andre-code andre-code force-pushed the 1867-expose-project-metadata-JSON-LD branch from c782cc9 to 8683aab Compare September 15, 2022 07:31
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 15, 2022 07:32 Inactive
@ciyer ciyer force-pushed the 1867-expose-project-metadata-JSON-LD branch from 8683aab to 2c2b805 Compare September 15, 2022 11:24
@ciyer ciyer temporarily deployed to renku-ci-ui-2022 September 15, 2022 11:25 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2022 September 15, 2022 13:07 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2022 September 15, 2022 13:25 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 19, 2022 06:03 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 19, 2022 07:38 Inactive
ciyer
ciyer previously approved these changes Sep 19, 2022
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andre-code andre-code force-pushed the 1867-expose-project-metadata-JSON-LD branch from 5f9a110 to 64f2071 Compare September 19, 2022 10:29
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 19, 2022 10:30 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 19, 2022 11:33 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 20, 2022 05:28 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2022 September 20, 2022 07:04 Inactive
@andre-code andre-code deployed to renku-ci-ui-2022 September 20, 2022 12:45 Active
@andre-code andre-code merged commit e42fc56 into master Sep 20, 2022
@andre-code andre-code deleted the 1867-expose-project-metadata-JSON-LD branch September 20, 2022 14:36
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose project metadata as JSON-LD markup/structured data
3 participants