feat: set jupyter server at first in Logs view (#1743) #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-2137.dev.renku.ch |
andre-code
force-pushed
the
1743-show-jupyter-server-as-default
branch
from
df0ee79 to
6fe10f2
Compare
andre-code
force-pushed
the
1743-show-jupyter-server-as-default
branch
from
6fe10f2 to
f9ad36e
Compare
andre-code
changed the title
There was a problem hiding this comment.
The code looks good!
I see the session logs acceptance test is failing, it probably requires tweaking it.
I noticed a bunch of visual details we could improve, but since they don't belong to this PR I made a new issue and added it to the sprint #2139
lorenzo-cavazzi
previously approved these changes
Nov 17, 2022
lorenzo-cavazzi
force-pushed
the
1743-show-jupyter-server-as-default
branch
from
52d6fbd to
89819a5
Compare
lorenzo-cavazzi
approved these changes
Nov 18, 2022
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to set Jupyter server at first in Logs view and don't show logs when there is no data case "download-image".
Closes #1743
/deploy #persist