Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis Sentinel support #2140

Closed
seanrmurphy opened this issue Nov 14, 2022 · 2 comments
Closed

Fix Redis Sentinel support #2140

seanrmurphy opened this issue Nov 14, 2022 · 2 comments

Comments

@seanrmurphy
Copy link

The current implementation does not have proper Redis Sentinel support, being unable to accept a list of sentinels. This issue arises in other services and there is Renku-Python issue open here:

SwissDataScienceCenter/renku-python#3204

To fix it, it is necessary to:

  • provide a mechanism by which a list of sentinels is made available to the UI server
  • modify the UI server such that these sentinels are used in the config of the Redis client

The specific way that this info will be provided via the helm chart has not been decided yet.

@lorenzo-cavazzi
Copy link
Member

@leafty
Copy link
Member

leafty commented Nov 6, 2023

I think this is obsolete because ioredis supports Sentinel and we configure the connection accordingly.

@github-project-automation github-project-automation bot moved this from Todo to Done in Renku UI board Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants