-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): Add pull session status websocket handler (#2016) #2145
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2145.dev.renku.ch |
679b8a4
to
28a941f
Compare
28a941f
to
5253850
Compare
5253850
to
6b46bb5
Compare
6b46bb5
to
64d55fe
Compare
d742a0c
to
3be4639
Compare
3be4639
to
80df1ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good! I have just a couple of changes, mainly to:
- prevent handling the auth headers in the low-level fetch functions
- store the minimum amount of data necessary when using
channel.data.set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, almost there! I have just another detail on how we handle server-side headers so that we can keep that coherent with the changes already done in the kg-search
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This works well!
I tested a bit more with anonymous users and I submitted a change to clean the headers (it should work but give it a quick test) along with a couple of other cosmetic changes. Nothing big, the PR is basically ready.
Also, give a run to npm run lint
on the "server" folder. There are a couple of lining errors but somehow the tests are not failing on that
…ept in Session page
feat(client): start pulling sessions status when the websocket is ready
…ng session when the websocket is open
…der type as in the kg-search api
0d17a4c
to
848d6ae
Compare
client: add case for url when project is called sessions
848d6ae
to
20de8ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well! Let's merge it 🚀
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR to add session status websocket handler.
*/sessions
,*/sessions/new
,*/sessions/show/*
).Closes #2016
/deploy #persist