Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): use project slug for links #2209

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Dec 9, 2022

When project creation succeeds but one of the following APIs fails (E.G. the webhook creation) the user gets a warning and can click on a "go to the project" button. The links was broken for projects with different name and slug.
This PR fixes it.

image

/deploy #persist #cypress

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner December 9, 2022 16:02
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2209 December 9, 2022 16:03 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 9, 2022

You can access the deployment of this PR at https://renku-ci-ui-2209.dev.renku.ch

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorenzo-cavazzi lorenzo-cavazzi merged commit 14cd2d2 into master Dec 12, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 000-fix-project-link branch December 12, 2022 09:30
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants