Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add entity list view styles (#2302) #2307

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jan 17, 2023

PR to add list view styles in entity component

Closes #2302

How to test

/deploy renku=000-connect-btn #persist #cypress

@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 17, 2023 13:14 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2307.dev.renku.ch

@andre-code andre-code force-pushed the 2302-entity-list-view branch from 097abe3 to 199082a Compare January 18, 2023 15:16
@andre-code andre-code changed the title WIP feat: add entity list view styles feat: add entity list view styles (#2302) Jan 18, 2023
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 18, 2023 15:19 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 18, 2023 16:14 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the 2302-entity-list-view branch from 199082a to cf8ab4c Compare January 19, 2023 09:56
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 19, 2023 09:56 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the 2302-entity-list-view branch from cf8ab4c to 2505531 Compare January 19, 2023 16:03
@andre-code andre-code marked this pull request as ready for review January 19, 2023 16:03
@andre-code andre-code requested a review from a team as a code owner January 19, 2023 16:03
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 19, 2023 16:04 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the 2302-entity-list-view branch from 2505531 to 87d1167 Compare January 20, 2023 07:17
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 07:17 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 07:37 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 09:16 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 10:45 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 11:01 — with GitHub Actions Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 20, 2023 13:17 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to fail consistently here. Maybe there is something to double-check.
Also, we should merge the Dashboard changes to a feature branch instead of master

@andre-code andre-code changed the base branch from master to 2286-dashboard January 24, 2023 07:29
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 24, 2023 08:05 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2307 January 24, 2023 08:56 — with GitHub Actions Inactive
@andre-code andre-code deployed to renku-ci-ui-2307 January 24, 2023 09:50 — with GitHub Actions Active
@andre-code andre-code merged commit 1f20402 into 2286-dashboard Jan 24, 2023
@andre-code andre-code deleted the 2302-entity-list-view branch January 24, 2023 12:55
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

andre-code added a commit that referenced this pull request Jan 27, 2023
andre-code added a commit that referenced this pull request Feb 1, 2023
lorenzo-cavazzi pushed a commit that referenced this pull request Feb 6, 2023
andre-code added a commit that referenced this pull request Feb 7, 2023
andre-code added a commit that referenced this pull request Feb 9, 2023
andre-code added a commit that referenced this pull request Feb 10, 2023
andre-code added a commit that referenced this pull request Feb 13, 2023
andre-code added a commit that referenced this pull request Feb 13, 2023
* feat: add entity list view (#2302)(#2307)
* feat: add project dashboard (#2303) (#2320)
* feat: add dataset dashboard (#2304)(#2330)
* feat: add session list view in dashboard (#2305)(#2333)
* feat: add get logs, stop session and link to Dashboard (#2305) (#2350)
* feat: modify the internal visibility icon, redirect to the dashboard when opening sessions page to authenticated users

Fix #2286

Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: Add entity component list view
4 participants