Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): add missing params to the notebook session button #2344

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

lorenzo-cavazzi
Copy link
Member

Fix the problem described here #2343

/deploy #persist #cypress renku=update-renku-ui-3.1.0
fix #2343

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner February 1, 2023 10:54
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2344 February 1, 2023 10:54 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 1, 2023

You can access the deployment of this PR at https://renku-ci-ui-2344.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2344 February 1, 2023 14:07 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2344 February 1, 2023 14:08 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi force-pushed the 2343-notebook-session-button branch from a4e3d60 to 1b385f5 Compare February 6, 2023 10:24
@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2344 February 6, 2023 10:25 — with GitHub Actions Active
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.🚀

@lorenzo-cavazzi lorenzo-cavazzi merged commit 12b813f into master Feb 6, 2023
@lorenzo-cavazzi lorenzo-cavazzi deleted the 2343-notebook-session-button branch February 6, 2023 13:07
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 6, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start session button for notebooks is broken
3 participants