fix(client): fix versionedUrlEndpoint()
#2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-2627.dev.renku.ch |
lorenzo-cavazzi
requested changes
Jul 3, 2023
| endpoint: string, | ||
| versionUrl: string | null | undefined | ||
| ) { | ||
| const urlPath = versionUrl ? `${versionUrl}/${endpoint}` : `/${endpoint}`; |
There was a problem hiding this comment.
Should we make this a bit more robust by always checking whether urlPath starts with /, adding it when that's not the case?
There was a problem hiding this comment.
I think this is a good idea. I believe there are code paths that add a /, so checking for that and adding a slash if necessary seems like a good strategy.
lorenzo-cavazzi
approved these changes
Jul 3, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can cause issue for projects using an unsupported metadata version.
/deploy #persist #cypress