Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show version of Renku and components in UI #2703

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Show version of Renku and components in UI #2703

merged 6 commits into from
Aug 4, 2023

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jul 28, 2023 •
edited
Loading

Fix #2664

Screenshot

image

/deploy #persist #cypress

@ciyer ciyer temporarily deployed to renku-ci-ui-2703 July 28, 2023 13:34 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2703.dev.renku.ch

ciyer pushed a commit that referenced this pull request Jul 28, 2023
@cramakri
feat: display renku chart version in UI (#2664) (#2703)
fccd782
ciyer pushed a commit that referenced this pull request Jul 28, 2023
@cramakri
feat: show version information on help page (#2664) (#2703)
64c0f30
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from 33da969 to 64c0f30 Compare July 28, 2023 15:53
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 July 28, 2023 15:53 — with GitHub Actions Inactive
ciyer pushed a commit that referenced this pull request Jul 31, 2023
@cramakri
feat: show version information on help page (#2664) (#2703)
c90f19f
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from 64c0f30 to c90f19f Compare July 31, 2023 10:16
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 July 31, 2023 10:17 — with GitHub Actions Inactive
ciyer pushed a commit that referenced this pull request Aug 2, 2023
@cramakri
feat: show version information on help page (#2664) (#2703)
b06e416
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from c90f19f to b06e416 Compare August 2, 2023 09:13
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 2, 2023 09:14 — with GitHub Actions Inactive
ciyer pushed a commit that referenced this pull request Aug 2, 2023
@cramakri
feat: show version information on help page (#2664) (#2703)
16e8f21
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from b06e416 to 16e8f21 Compare August 2, 2023 10:15
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 2, 2023 10:15 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 07:57 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from 16e8f21 to 37461ac Compare August 3, 2023 09:21
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 09:21 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review August 3, 2023 09:22
@ciyer ciyer requested a review from a team as a code owner August 3, 2023 09:22
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from 2813c6b to 37461ac Compare August 3, 2023 09:59
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 10:00 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 10:57 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the version number(s) in the UI 🎉

The solution is neat and works well already! I added a couple of inline comments, just minor details to address before merging.

leafty
leafty reviewed Aug 3, 2023
View reviewed changes
client/src/help/HelpRelease.tsx
useGetNotebooksVersionsQuery,
} from "../features/versions/versionsApi";

type Params = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

Suggested change
type Params = {
interface Params {

client/src/help/HelpRelease.tsx
Comment on lines +221 to +224
export default HelpRelease;

// For testing
export { parseChartVersion };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exports at definition site

@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 12:13 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/2664-show-version branch from 6a3b01d to 03a9f0e Compare August 3, 2023 12:31
@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 12:31 — with GitHub Actions Inactive
@ciyer
Copy link
Contributor Author

ciyer commented Aug 3, 2023

Thanks for the reviews! I think I have addressed the key comments and the PR is ready for re-review.

@ciyer ciyer temporarily deployed to renku-ci-ui-2703 August 3, 2023 13:06 — with GitHub Actions Inactive
@ciyer ciyer requested a review from lorenzo-cavazzi August 3, 2023 13:59
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2703 August 3, 2023 15:23 — with GitHub Actions Active
@ciyer ciyer merged commit 82d56d5 into master Aug 4, 2023
@ciyer ciyer deleted the ciyer/2664-show-version branch August 4, 2023 08:00
@RenkuBot
Copy link
Contributor

RenkuBot commented Aug 4, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty left review comments

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
UI Sprints - DEPRECATED
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference to the currently deployed release in the UI
5 participants
@ciyer @RenkuBot @leafty @lorenzo-cavazzi @cramakri