-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add project slug tooltip to each link in the linked projects list (#2617) #2707
Merged
andre-code
merged 6 commits into
master
from
2617-show-friendly-name-slug-in-other-links
Aug 7, 2023
Merged
feat: Add project slug tooltip to each link in the linked projects list (#2617) #2707
andre-code
merged 6 commits into
master
from
2617-show-friendly-name-slug-in-other-links
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can access the deployment of this PR at https://renku-ci-ui-2707.dev.renku.ch |
83da3c2
to
0c0bd64
Compare
lorenzo-cavazzi
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well!
Just a tiny detail in the import
section.
Co-authored-by: Lorenzo Cavazzi <[email protected]>
9a80c87
to
552c238
Compare
lorenzo-cavazzi
approved these changes
Aug 2, 2023
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add a tooltip in the list of linked projects in the dataset view.
The friendly name was already displayed, so we included the slug as a tooltip to differentiate the project name, it is necessary when the dataset is used in several projects that have the same name.
Fix #2617
/deploy #persist renku=renku-ui/3.11-acceptance-tests