Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add project slug tooltip to each link in the linked projects list (#2617) #2707

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Aug 2, 2023

PR to add a tooltip in the list of linked projects in the dataset view.
The friendly name was already displayed, so we included the slug as a tooltip to differentiate the project name, it is necessary when the dataset is used in several projects that have the same name.

tooltip in project list

Fix #2617

/deploy #persist renku=renku-ui/3.11-acceptance-tests

@andre-code andre-code requested a review from a team as a code owner August 2, 2023 06:42
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 06:43 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Aug 2, 2023

You can access the deployment of this PR at https://renku-ci-ui-2707.dev.renku.ch

@andre-code andre-code force-pushed the 2617-show-friendly-name-slug-in-other-links branch from 83da3c2 to 0c0bd64 Compare August 2, 2023 06:56
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 06:56 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 08:40 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well!
Just a tiny detail in the import section.

@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 10:12 — with GitHub Actions Inactive
@andre-code andre-code force-pushed the 2617-show-friendly-name-slug-in-other-links branch from 9a80c87 to 552c238 Compare August 2, 2023 11:47
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 11:48 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 12:04 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 2, 2023 14:38 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 3, 2023 08:23 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2707 August 3, 2023 12:24 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2707 August 3, 2023 15:28 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2707 August 4, 2023 13:01 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi deployed to renku-ci-ui-2707 August 7, 2023 07:07 — with GitHub Actions Active
@andre-code andre-code merged commit 36672f2 into master Aug 7, 2023
@andre-code andre-code deleted the 2617-show-friendly-name-slug-in-other-links branch August 7, 2023 09:05
@RenkuBot
Copy link
Contributor

RenkuBot commented Aug 7, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show projects using datasets with fully qualified names
3 participants