Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client): fix uses of bootstrap icons #2772

Merged
merged 5 commits into from
Sep 6, 2023
Merged

chore(client): fix uses of bootstrap icons #2772

merged 5 commits into from
Sep 6, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Aug 29, 2023 •
edited
Loading

Details:

  • remove icon imports from ts-wrappers.js
  • adjust icon alignment in entity header card
  • add "bi" (bootstrap icon) class name for inline use with text

Screenshot 2023-09-05 at 15 45 34

/deploy #persist

@leafty leafty temporarily deployed to renku-ci-ui-2772 August 29, 2023 11:59 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2772.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-2772 August 29, 2023 12:27 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2772 September 5, 2023 11:34 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2772 September 5, 2023 11:54 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review September 5, 2023 13:46
@leafty leafty requested a review from a team as a code owner September 5, 2023 13:46
ciyer
ciyer approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice cleanup!

@leafty leafty merged commit 2521625 into master Sep 6, 2023
@leafty leafty deleted the leafty/adjust-bootstrap-icons branch September 6, 2023 07:55
@RenkuBot
Copy link
Contributor

RenkuBot commented Sep 6, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @ciyer