fix(datasets): dataset_name changed to short_name #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfried
force-pushed
the
907-dataset-short-name
branch
2 times, most recently
from
f5e7351 to
bed6afd
Compare
ciyer
requested changes
Apr 22, 2020
There was a problem hiding this comment.
Code makes sense. Could you just add a reference to the PR and issue in the commit message? And could you add that there is a breaking change here, since this needs a new version of a backend component?
https://www.conventionalcommits.org/en/v1.0.0/#summary
vfried
force-pushed
the
907-dataset-short-name
branch
from
bed6afd to
4301dce
Compare
vfried
added a commit
that referenced
this pull request
Apr 22, 2020
BREAKING_CHANGE: dataset_name changed to short_name in the backend (renku-core)
vfried
force-pushed
the
907-dataset-short-name
branch
from
4301dce to
e205edd
Compare
Done! |
vfried
added a commit
that referenced
this pull request
Apr 23, 2020
BREAKING_CHANGE: dataset_name changed to short_name in the backend (renku-core)
vfried
force-pushed
the
907-dataset-short-name
branch
from
e205edd to
8ee6d83
Compare
BREAKING_CHANGE: dataset_name changed to short_name in the backend (renku-core)
vfried
force-pushed
the
907-dataset-short-name
branch
from
8ee6d83 to
4ddfa12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"dataset_name" inside the core service changed to "short_name" this will allow us to use in the future for "dataset_name" a proper title with spaces and short name would be the title that we have now.
For testing this in your own env you need to have the latest version of renku-core(0.10.3-cf08d03)