Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify session's dropdown button for project's entity header and dashboard #2393

Closed
lorenzo-cavazzi opened this issue Feb 23, 2023 · 0 comments · Fixed by #2401
Closed

Unify session's dropdown button for project's entity header and dashboard #2393

lorenzo-cavazzi opened this issue Feb 23, 2023 · 0 comments · Fixed by #2401
Assignees
@lorenzo-cavazzi

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Feb 23, 2023 •
edited
Loading

Motivation

We have a new dropdown button for sessions in the dashboard. That changes depending on the session status.
We still have a more static button in the project entity-header.

image

image

Proposal

We should use the same button on the header.
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Feb 24, 2023
Merged
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Mar 8, 2023
@lorenzo-cavazzi lorenzo-cavazzi moved this from Todo to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Mar 8, 2023
lorenzo-cavazzi added a commit that referenced this issue Mar 17, 2023
@lorenzo-cavazzi
feat(client): unify dashboard and headers session buttons
8b32d35 
* re-use the same components
* save support data to Redux instad of to local components
* improve dashboard (prevent flashing sessions, use shared links and buttons)
* swap start buttons with clickable links
* swap stop icon with the non-circled version

fix #2393
@lorenzo-cavazzi lorenzo-cavazzi moved this from In Progress 🧑‍💻 to Review 🔎 in UI Sprints - DEPRECATED Mar 17, 2023
@github-project-automation github-project-automation bot moved this from Review 🔎 to Done ✅ in UI Sprints - DEPRECATED Mar 20, 2023
lorenzo-cavazzi added a commit that referenced this issue Mar 20, 2023
@lorenzo-cavazzi
feat(client): unify dashboard and headers session buttons (#2401)
7a4a5b6 
* re-use the same components
* save support data to Redux instead of to local components
* improve dashboard (prevent flashing sessions, use shared links and buttons)
* swap start buttons with clickable links
* swap the stop icon with the non-circled version

fix #2393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
None yet
Projects
No open projects
UI Sprints - DEPRECATED
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify dashboard and project heard session dropdown buttons SwissDataScienceCenter/renku-ui
1 participant
@lorenzo-cavazzi