-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): new design for renku docs #2166
Conversation
You can access the deployment of this PR at https://ci-renku-2166.dev.renku.ch |
This looks really great!! Do you think it would be possible to apply these changes to the renku sphinx theme? That way the other repos that might publish their own documentation pages can use the same theme |
Yes, that's a good point... i spoke with ralph this morning to apply this to renku python but it would be easier to apply only to one place. At the moment we are not using the renku theme, we are using the read the docs one and this changes apply to the read the docs theme... https://github.com/readthedocs/sphinx_rtd_theme we could fork these theme and apply this design there. |
I know we're not using it now, but we used to use it so the repo is already there. It's fine if it's completely overwritten, but having it there would make it easier to maintain. |
I will see how i can overwrite the theme in the renku repo then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice! 🎉
The suggestions Rok made make sense to me as well. As part of that conversion, I found a couple of files that should probably be removed (see comments), and, as we discussed, I think it would be nice if the css were autogenerated from the scss files (which might require changes to the config and the makefile), but if that is complicated to do, it should be at least documented that the css files should not be edited and how they can be generated.
I will do a full review after the restructuring, but I have already looked at the changes, so I do not expect anything major -- it looks very good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look great!
afcf1a3
to
f5e407e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
New design for docs
/deploy