Add Support for xunit.v3 #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for xunit.v3 Signed-off-by: Jonas Bengtsson <[email protected]>
alexanderlinne
requested changes
Feb 14, 2025
| <PackageTags>test;arch;archunit;xunit</PackageTags> | ||
| <IncludeSource>False</IncludeSource> | ||
| <Company>TNG Technology Consulting GmbH</Company> | ||
| <PackageId>TngTech.ArchUnitNET.xUnit.v3</PackageId> |
There was a problem hiding this comment.
Suggested change
| <PackageId>TngTech.ArchUnitNET.xUnit.v3</PackageId> | |
| <PackageId>TngTech.ArchUnitNET.xUnitV3</PackageId> |
Change the package name to be similar to the existing MSTest package
There was a problem hiding this comment.
I have added two test projects:
TngTech.ArchUnitNET.xUnitTestsTngTech.ArchUnitNET.xUnitV3Tests
Previously there were no test project for TngTech.ArchUnitNET.xUnit.
There was a problem hiding this comment.
Yeah, xUnit didn't need additional tests cause ArchUnitNETTests uses xUnit, so it's tested through that project. But probably doesn't hurt to have them 👍
Co-authored-by: Alexander Linne <[email protected]> Signed-off-by: Jonas Bengtsson <[email protected]>
Signed-off-by: Jonas Bengtsson <[email protected]>
Signed-off-by: Jonas Bengtsson <[email protected]>
Signed-off-by: Jonas Bengtsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for xunit.v3
Fixes: #338