Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix PolarisRouterServiceInstanceListSupplier npe with reactive feign #925

Conversation

ShanyouYu-Sean
Copy link
Contributor

PR Type

Bugfix.

Describe what this PR does for and how you did.

fix PolarisRouterServiceInstanceListSupplier npe with reactive feign(a third party dependency)

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2020.0.
  • Will pull request to branch of 2022.0.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #925 (bc81a3b) into 2020.0 (5b56424) will increase coverage by 0.18%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             2020.0     #925      +/-   ##
============================================
+ Coverage     80.03%   80.21%   +0.18%     
- Complexity     1326     1330       +4     
============================================
  Files           206      206              
  Lines          4502     4503       +1     
  Branches        561      562       +1     
============================================
+ Hits           3603     3612       +9     
+ Misses          557      550       -7     
+ Partials        342      341       -1     
Impacted Files Coverage Δ
...uter/PolarisRouterServiceInstanceListSupplier.java 90.32% <66.66%> (+13.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SkyeBeFreeman SkyeBeFreeman merged commit 1f4a3bc into Tencent:2020.0 Mar 30, 2023
@SkyeBeFreeman SkyeBeFreeman added this to the 1.10.3 milestone Mar 30, 2023
@ShanyouYu-Sean ShanyouYu-Sean deleted the dev/sean/fix_reactive_feign_npe_2020 branch May 8, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants