Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly Number With Recursion (Addition of Ugly Number Problem #1286) #1424

Merged
merged 8 commits into from
Dec 9, 2020

Conversation

ErzaTitania-2001
Copy link
Contributor

@ErzaTitania-2001 ErzaTitania-2001 commented Dec 5, 2020

Have you read the Contributing Guidelines on Pull Requests?

(Write your answer here.)

Yes

(Write your answer here.)

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.
  • I've edited the README.md and link to my code.

Related Issues or Pull Requests

Addition of Ugly Number Problem #1286

Copy link
Contributor

@iamrajiv iamrajiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErzaTitania-2001 Do not mix ArmStrongRecursion.java and UglyRecursion.java programs in the same PR. You can make separate PR for ArmStrongRecursion.java program.

@@ -0,0 +1,48 @@
//finding nth ugly number using recursion
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite new to GitHub. Sorry for the troubles.
Ugly Problem link : #1286
PDDI Problem link : #1217

Copy link
Contributor Author

@ErzaTitania-2001 ErzaTitania-2001 Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamrajiv @atarax665 when is this pull request going to be resolved? Should I open two new PRs for each code individually?

@iamrajiv iamrajiv requested a review from atarax665 December 5, 2020 16:07
@@ -0,0 +1,48 @@
//finding nth ugly number using recursion
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite new to GitHub. Sorry for the troubles.
Ugly Problem link : #1286
PDDI Problem link : #1217

@iamrajiv iamrajiv merged commit 146b093 into HarshCasper:master Dec 9, 2020
@iamrajiv
Copy link
Contributor

iamrajiv commented Dec 9, 2020

@all-contributors please add @ErzaTitania-2001 for code

@allcontributors
Copy link
Contributor

@iamrajiv

I've put up a pull request to add @ErzaTitania-2001! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants